[Freeipmi-devel] [bug #40076] Does not differentiate between different OEM-SEL record types

[Rob Swindell]

URL:
  <http://savannah.gnu.org/bugs/?40076>

                 Summary: Does not differentiate between different OEM-SEL
record types
                 Project: GNU FreeIPMI
            Submitted by: rswindell
            Submitted on: Sat 21 Sep 2013 01:40:30 AM GMT
                Category: ipmi-sel
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Improper Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None

    _______________________________________________________

Details:

OEM-SEL entries may have types from 0xC0 through 0xFF, but the ipmi-sel
program just output "OEM defined", not differentiating between the different
potential OEM-defined record types.

This patch displays the actual 'record type' value for OEM-defined SEL
entries. This allows parsers to differentiate between OEM type 0xE0 and 0xE1
for example and interpet the OEM-defined entry data accordingly.

Example ipmi-sel output from before the patch:

3  | N/A         | N/A      | N/A             | N/A                         |
OEM defined = DEh CEh 3Ch 52h 01h 00h 00h 39h 00h 00h 04h 05h 00h

Example ipmi-sel output from after the patch:

3  | N/A         | N/A      | N/A             | N/A                         |
OEM E4h defined = DEh CEh 3Ch 52h 01h 00h 00h 39h 00h 00h 04h 05h 00h

If you prefer to put the record-type in parenthesis or after the word
"defined", that would be fine too, but tools which parse OEM-defined entries
the output of ipmi-sel will need to know the exact record type value.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 21 Sep 2013 01:40:30 AM GMT  Name: oem_sel_type.patch  Size: 571B  
By: rswindell
Patch created with &quot;svn diff&quot; which addresses the issue described.
<http://savannah.gnu.org/bugs/download.php?file_id=29188>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40076>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/