freeipmi-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Freeipmi-devel] ipmipower --wait-until command line argument parsin


From: Albert Chu
Subject: Re: [Freeipmi-devel] ipmipower --wait-until command line argument parsing fix
Date: Wed, 08 Nov 2017 14:59:16 -0800

Doh!  Thanks for the catch.  Most users use both at the same time,
which is probably why this was not caught for the longest time.  

Thanks.

Al

On Wed, 2017-11-08 at 21:13 +0000, Michel Ferland wrote:
> Hello,
> 
> The --wait-until-on and --wait-until-off command line arguments to
> ipmipower are not working, as their respective keys are inverted in
> the command line parsing function. Fixed by patch below.
> 
> Thank you,
> 
> 
> Michel Ferland
> Concepteur logiciel
> Software Designer
> Kontron - An S&T Company
> ---
> 
> diff -pur freeipmi-1.5.7.orig/ipmipower/ipmipower_argp.c freeipmi-
> 1.5.7/ipmipower/ipmipower_argp.c
> --- freeipmi-1.5.7.orig/ipmipower/ipmipower_argp.c    2017-11-07
> 09:16:50.523751999 -0500
> +++ freeipmi-1.5.7/ipmipower/ipmipower_argp.c 2017-11-07
> 09:20:12.915751999 -0500
> @@ -215,10 +215,10 @@ cmdline_parse (int key,
>      case ON_IF_OFF_KEY:       /* --on-if-off */
>        cmd_args->on_if_off++;
>        break;
> -    case WAIT_UNTIL_OFF_KEY:       /* --wait-until-on */
> +    case WAIT_UNTIL_ON_KEY:       /* --wait-until-on */
>        cmd_args->wait_until_on++;
>        break;
> -    case WAIT_UNTIL_ON_KEY:       /* --wait-until-off */
> +    case WAIT_UNTIL_OFF_KEY:       /* --wait-until-off */
>        cmd_args->wait_until_off++;
>        break;
>      case OEM_POWER_TYPE_KEY:
> 
> 
> _______________________________________________
> Freeipmi-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/freeipmi-devel
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory




reply via email to

[Prev in Thread] Current Thread [Next in Thread]