[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Freeipmi-devel] [RFC][PATCH 0/1] Fix apparent bug w/ ACPI SPMI table pa

From: dann frazier
Subject: [Freeipmi-devel] [RFC][PATCH 0/1] Fix apparent bug w/ ACPI SPMI table parsing
Date: Mon, 30 Jul 2018 15:30:44 -0600

  I'm working on a patch to add support to ipmi-locate code to parse ACPI
SPMI tables via sysfs. This is to make ipmi-locate work on an ARM system
we have that describes its BMC only in ACPI (not DMI). Being ARM, trolling
/dev/mem isn't safe, (freeipmi ifdef's that out), so using the kernel-exposed
tables, when available, is a better option.

While doing this I ran across what seems like a bug, which the following patch
should fix. I say "seems" and "should" because I don't have a system where the
existing /dev/mem snooping code works - with, or without this bug fix -
therefore, I cannot emperically demonstrate the bug. On the systems I've
tested, which do include an SPMI table, ipmi-locate is unable to find a valid
RSDT signature using the /dev/mem method. I'm not sure what I'm doing wrong
there - I tried diabling CONFIG_STRICT_DEVMEM andsetting the vm.mmap_min_addr
sysctl to 0 w/o luck.

dann frazier (1):
  Don't try to separate the header from the ACPI table data

 libfreeipmi/locate/ipmi-locate-acpi-spmi.c | 33 +++-------------------
 1 file changed, 4 insertions(+), 29 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]