freepooma-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pooma-dev] Re: [PATCH] MPI support for SerialAsync scheduler


From: Richard Guenther
Subject: Re: [pooma-dev] Re: [PATCH] MPI support for SerialAsync scheduler
Date: Mon, 5 Jan 2004 23:15:53 +0100 (CET)

On Mon, 5 Jan 2004, Jeffrey D. Oldham wrote:

> Richard Guenther wrote:
> > The patch was tested as usual.
> >
> > Ok to commit?
>
> I have some questions and comments interspersed below.
>
> > Thanks, Richard.
> >
> >
> > 2004Jan02  Richard Guenther <address@hidden>
> >
> >     * src/Threads/IterateSchedulers/SerialAsync.h: doxygenifize,
> >     add std::stack<int> for generation tracking, add support for
> >     asyncronous MPI requests.
>
> Add an 'h' to spell asynchronous.

Ok.

> > +/**
> > + * FIXME.
> > + */
>
> I am wary of adding unfinished code to the code base.  At the very
> least, we need a more extensive comment describing what is not finished.

Oh, it's just missing documentation of struct SystemContext.  I'll strip
the FIXME.

Ok with this change?

Thanks,

Richard.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]