freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [freetype2] priyesh_LogLibrary 92847d8: * builds/windows/ftdebug.c (


From: Werner LEMBERG
Subject: Re: [freetype2] priyesh_LogLibrary 92847d8: * builds/windows/ftdebug.c (ft_log_handler): Updated code according to the
Date: Mon, 24 Aug 2020 09:57:07 +0200 (CEST)

Hello Priyesh,


> +    if( ft_getenv( "FT_LOGGING_FILE" ) )
> +    {
> +      ft_fileptr = fopen( ft_getenv( "FT_LOGGING_FILE" ) , "w" );
> +    }    
> +    else 
> +    {
> +      ft_fileptr = stderr;
> +    }

Minor issue: The coding style in FreeType doesn't use braces for
conditionals if there is only a single line.  In other words, code
like the above should rather be

  if ( ft_getenv( "FT_LOGGING_FILE" ) )
    ft_fileptr = fopen( ft_getenv( "FT_LOGGING_FILE" ), "w" );
  else 
    ft_fileptr = stderr;


     Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]