freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[freetype2] master 5e227133c: [pshinter] Avoid accessing uninitialized z


From: Werner Lemberg
Subject: [freetype2] master 5e227133c: [pshinter] Avoid accessing uninitialized zone.
Date: Sat, 15 Jan 2022 18:05:30 -0500 (EST)

branch: master
commit 5e227133c16c1c9ff41a18a2b411a20afe81be6c
Author: Ben Wagner <bungeman@chromium.org>
Commit: Ben Wagner <bungeman@chromium.org>

    [pshinter] Avoid accessing uninitialized zone.
    
    The `normal_top.count` may be 0, implying no `normal_top.zones` exist.
    The code must not access these (non-existent) `normal_top.zones`.
    
    * src/pshinter/pshalgo.c (ps_hints_apply): Do not assume that
    `normal_top.zones[0]` is initialized. Test `normal_top.count`
    before using `normal_top.zones[0]`. Do not rescale if there are no
    `zones`.
    
    Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43675
---
 src/pshinter/pshalgo.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/pshinter/pshalgo.c b/src/pshinter/pshalgo.c
index d68426359..1616c43fb 100644
--- a/src/pshinter/pshalgo.c
+++ b/src/pshinter/pshalgo.c
@@ -2110,14 +2110,17 @@
       FT_Fixed  old_x_scale = x_scale;
       FT_Fixed  old_y_scale = y_scale;
 
-      FT_Fixed  scaled;
-      FT_Fixed  fitted;
+      FT_Fixed  scaled = 0;
+      FT_Fixed  fitted = 0;
 
       FT_Bool  rescale = FALSE;
 
 
-      scaled = FT_MulFix( globals->blues.normal_top.zones->org_ref, y_scale );
-      fitted = FT_PIX_ROUND( scaled );
+      if ( globals->blues.normal_top.count )
+      {
+        scaled = FT_MulFix( globals->blues.normal_top.zones->org_ref, y_scale 
);
+        fitted = FT_PIX_ROUND( scaled );
+      }
 
       if ( fitted != 0 && scaled != fitted )
       {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]