[Git][freetype/freetype-demos][master] [ftinspect] Change unclear commen

Charlie Jiang pushed to branch master at FreeType / FreeType Demo Programs

Commits:

9ac95b36

by Charlie Jiang at 2022-10-04T00:17:08+08:00

[ftinspect] Change unclear comments.

* src/ftinspect/engine/fontinfo.hpp,
  src/ftinspect/glyphcomponents/glyphcontinuous.cpp: Clearify comments.

* src/ftinspect/maingui.cpp: Actually the left widget does more than
  setting the margin, so the comment line about removing the left widget and
  layout is removed.

3 changed files:

src/ftinspect/engine/fontinfo.hpp
src/ftinspect/glyphcomponents/glyphcontinuous.cpp
src/ftinspect/maingui.cpp

Changes:

src/ftinspect/engine/fontinfo.hpp

@@ -223,7 +223,7 @@ struct FontFixedSize
    double xPpem;
    double yPpem;
 -  // Returns that if the list is updated.  WL: ???
 +  // Returns `true` when the list is actually updated.
    // We use a callback because Qt needs `beginResetModel` to be called
    // *before* the internal storage updates.
    static bool get(Engine* engine,

src/ftinspect/glyphcomponents/glyphcontinuous.cpp

@@ -205,7 +205,8 @@ GlyphContinuous::mouseMoveEvent(QMouseEvent* event)
+   {
      positionDelta_ = prevPositionDelta_ + delta;
      positionDelta_.setX(0); // Don't move horizontally.
 -    // but use the renderer // WL: ???
 +    // The string renderer will handle the horizontal delta. See below.
++
      // Note the double use of `scale_`: one for undoing `delta /= scale_`,
      // the other one for effectively dividing the width by the scaling
      // factor.

src/ftinspect/maingui.cpp

@@ -267,7 +267,7 @@ MainGUI::createLayout()
    // left side
    settingPanel_ = new SettingPanel(this, engine_);
 -  leftLayout_ = new QVBoxLayout; // The only point is to set `margin->remove`?
 +  leftLayout_ = new QVBoxLayout;
    leftLayout_->addWidget(settingPanel_);
    leftLayout_->setContentsMargins(32, 32, 0, 16);

From:	Charlie Jiang (@cqjjjzr)
Subject:	[Git][freetype/freetype-demos][master] [ftinspect] Change unclear comments.
Date:	Tue, 04 Oct 2022 00:29:50 +0000