[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft] [ft-devel] Large code changes without changing functionality
From: |
Werner LEMBERG |
Subject: |
Re: [ft] [ft-devel] Large code changes without changing functionality |
Date: |
Fri, 15 Mar 2013 08:45:38 +0100 (CET) |
> Why no FT_THROW here:
>
> - error = FT_Err_Invalid_Argument;
> + error = FT_ERR( Invalid_Argument );
This is a simple error code assignment; there's some code in FreeType
which starts with a non-zero error code as the default which gets
overridden later on. In other words, the assignment itself is not an
error condition which should be caught by FT_THROW.
In the end, this kind of FreeType code should be rewritten to always
start with FT_Err_Ok. However, this is a major undertaking -- quite
easy to do, but a lot of work. Right now, I guess that 95% of `real'
errors are handled by FT_THROW.
Werner