g-wrap-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Allow null-ok in wct types


From: Andy Wingo
Subject: Re: [PATCH] Allow null-ok in wct types
Date: Mon, 30 Oct 2006 11:02:04 +0100

Hi Ludovic,

On Mon, 2006-10-30 at 10:34 +0100, Ludovic Courtès wrote:
> what's this:
> 
> #v+
> --- orig/guile/g-wrap/guile.scm
> +++ mod/guile/g-wrap/guile.scm
> @@ -52,6 +52,10 @@
>           <gw-guile-rti-type>
>           scm-var))
>  
> +(module-use! (module-public-interface (current-module))
> +             (resolve-interface '(g-wrap c-codegen)))
> +(module-use! (module-public-interface (current-module))
> +             (resolve-interface '(g-wrap scm-codegen)))

This could be written as (re-export-module (g-wrap c-codegen)) with a
suitable macro. It is to preserve compatibility: sometime after 1.9.6
Andreas split out some of the functionality into the c-codegen and
scm-codegen modules. This change makes using (g-wrap guile) export the
same set of bindings as before.

I could change guile-gnome, but it seems gratuitous to force a change.

> @@ -886,31 +890,38 @@
>                     (hashq-create-handle! gf-hash gf-name '())))
>                (set-cdr! handle (cons func (cdr handle)))))))
>         #f wrapset)
> -       (hash-fold
> -        (lambda (gf funcs rest)
> -          (for-each
> -           (lambda (func)
> -             (write
[...]

This one was replacing tabs with spaces, as noted in the commit log.

Regards,

Andy.
-- 
http://wingolog.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]