[Gcl-devel] More code cleanup...

[Robert Alan Byer]

-----BEGIN PGP SIGNED MESSAGE-----


More minor things I've discovered...

gcl/bin/append.c 
Has carriage returns at the end of each line giving compilers fits. This 
needs to be taken care of.

gcl/bin/file-sub.c
Had to place an #include <string.h> to keep the Tru64 & OpenVMS compilers
from complaing about strlen being an implicitly declared function.  For 
OpenVMS I had to also add #include <stdlib.h> which I #ifdef'd specifically 
for OpenVMS so that it wouldn't bitch about the exit function being implicitly
declared.

gcl/bin/dpp.c
Had to place an #include <string.h> to keep the Tru64 & OpenVMS compilers 
from complaining about strcmp beind an implicitly declared function.  For 
OpenVMS I had to also add #include <stdlib.h> which I #ifdef'd specifically 
for OpenVMS so that it wouldn't bitch about the exit function being
implicitly declared.

gcl/o/cmpaux.c
gcl/o/fasldlsym.c
gcl/o/main.c
gcl/o/symbol.d
gcl/o/unixfsys.c
Had to place an #include <string.h> to keep the Tru64 & OpenVMS compilers
from complaing about strlen being an implicitly declared function.

Also, I don't recall seeing this one before when compiling the libgmp, but 
I got the following when compiling gcl/gmp/compat.c under Tru64.

cc: Warning: compat.c, line 31: Non-void function "__gmpn_divexact_by3" 
does not contain a return statement. (missingreturn)
int
^
cc: Warning: compat.c, line 40: Non-void function "__gmpn_divmod_1" does 
not contain a return statement. (missingreturn)
int
^

Attached is a CVS diff file with the patches I made the above listed files 
(with the exception of gcl/gmp.compat.c).

I have alot more comming :}

===========================================================================

Index: gcl//bin/dpp.c
===================================================================
RCS file: /cvsroot/gcl/gcl/bin/dpp.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 dpp.c
- --- gcl//bin/dpp.c    6 Dec 1999 22:43:55 -0000       1.1.1.1
+++ gcl//bin/dpp.c      18 Dec 2001 16:09:01 -0000
@@ -61,6 +61,17 @@
 
 #include <stdio.h>
 
+/*
+ * Modification By:  Robert Byer <address@hidden>
+ *
+ * This keeps the Tru64 DEC C compiler from bitching about strcmp being an
+ * implicitly declared.  For OpenVMS we also include <stdlib.h> so that it
+ * won't bitch about the exit function being implicitly declared.
+ */
+#include <string.h>
+#if defined(__DECC) && defined(VMS)
+# include <stdlib.h>
+#endif
 
 #ifdef UNIX
 #include <ctype.h>
Index: gcl//bin/file-sub.c
===================================================================
RCS file: /cvsroot/gcl/gcl/bin/file-sub.c,v
retrieving revision 1.1
diff -u -r1.1 file-sub.c
- --- gcl//bin/file-sub.c       9 Dec 2000 07:10:35 -0000       1.1
+++ gcl//bin/file-sub.c 18 Dec 2001 16:09:01 -0000
@@ -6,6 +6,19 @@
 
 #include <stdio.h>
 
+/*
+ * Modification By:  Robert Byer <address@hidden>
+ *
+ * This keeps the Tru64 DEC C compiler from bitching about strlen being an
+ * implicitly declared and changing the return type from size_t to int.  For
+ * OpenVMS we also include <stdlib.h> so that it won't bitch about the
+ * exit function being implicitly declared.
+ */
+#include <string.h>
+#if defined(__DECC) && defined(VMS)
+# include <stdlib.h>
+#endif
+
 void scanCopyToLine(FILE *fp, char *line,FILE *outstream);
 
 main(int argc,char *argv[])
Index: gcl//o/cmpaux.c
===================================================================
RCS file: /cvsroot/gcl/gcl/o/cmpaux.c,v
retrieving revision 1.2
diff -u -r1.2 cmpaux.c
- --- gcl//o/cmpaux.c   6 May 2001 15:59:23 -0000       1.2
+++ gcl//o/cmpaux.c     18 Dec 2001 16:09:02 -0000
@@ -25,6 +25,15 @@
 */
 #define NEED_MP_H
 #include "include.h"
+
+/*
+ * Modification By:  Robert Byer <address@hidden>
+ *
+ * This keeps the Tru64 DEC C compiler from bitching about strlen being an
+ * intrinsic function and changing the return type from size_t to int.
+ */
+#include <string.h>
+
 #define dcheck_type(a,b) check_type(a,b)
 
 DEFUNO("SPECIALP",object,fSspecialp,SI
Index: gcl//o/fasldlsym.c
===================================================================
RCS file: /cvsroot/gcl/gcl/o/fasldlsym.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 fasldlsym.c
- --- gcl//o/fasldlsym.c        6 Dec 1999 22:44:10 -0000       1.1.1.1
+++ gcl//o/fasldlsym.c  18 Dec 2001 16:09:02 -0000
@@ -28,6 +28,14 @@
 #include <elf.h>
 #endif
 
+/*
+ * Modification By:  Robert Byer <address@hidden>
+ *
+ * This keeps the Tru64 DEC C compiler from bitching about strlen being an
+ * intrinsic function and changing the return type from size_t to int.
+ */
+#include <string.h>
+
 /* cc -DVOL=volatile -G 0 -c foo.c ; ld  -shared foo.o -o jim.o ; cat foo.data 
>> jim.o */
 int did_a_dynamic_load;
 
Index: gcl//o/main.c
===================================================================
RCS file: /cvsroot/gcl/gcl/o/main.c,v
retrieving revision 1.5
diff -u -r1.5 main.c
- --- gcl//o/main.c     15 May 2001 05:58:28 -0000      1.5
+++ gcl//o/main.c       18 Dec 2001 16:09:02 -0000
@@ -36,10 +36,17 @@
 #include "include.h"
 #ifdef UNIX
 #include <signal.h>
- -
- -
 #endif
+
 #include "page.h"
+
+/*
+ * Modification By:  Robert Byer <address@hidden>
+ *
+ * This keeps the Tru64 DEC C compiler from bitching about strlen being an
+ * intrinsic function and changing the return type from size_t to int.
+ */
+#include <string.h>
 
 bool saving_system ;
 
Index: gcl//o/symbol.d
===================================================================
RCS file: /cvsroot/gcl/gcl/o/symbol.d,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 symbol.d
- --- gcl//o/symbol.d   6 Dec 1999 22:44:13 -0000       1.1.1.1
+++ gcl//o/symbol.d     18 Dec 2001 16:09:05 -0000
@@ -24,6 +24,14 @@
 
 #include "include.h"
 
+/*
+  Modification By:  Robert Byer
+ 
+  This keeps the Tru64 DEC C compiler from bitching about strlen being an
+  intrinsic function and changing the return type from size_t to int.
+*/
+#include <string.h>
+
 object siSpname;
 
 set_up_string_register(s)
Index: gcl//o/unixfsys.c
===================================================================
RCS file: /cvsroot/gcl/gcl/o/unixfsys.c,v
retrieving revision 1.3
diff -u -r1.3 unixfsys.c
- --- gcl//o/unixfsys.c 6 May 2001 15:59:23 -0000       1.3
+++ gcl//o/unixfsys.c   18 Dec 2001 16:09:05 -0000
@@ -27,6 +27,14 @@
 #include <pwd.h>
 #endif
 
+/*
+ * Modification By:  Robert Byer <address@hidden>
+ *
+ * This keeps the Tru64 DEC C compiler from bitching about strlen being an
+ * intrinsic function and changing the return type from size_t to int.
+ */
+#include <string.h>
+
 #ifdef BSD
 #define HAVE_RENAME
 #endif

===========================================================================


 +------------------+--------------------------+---------------+
 | Robert Alan Byer | address@hidden | ICQ #65926579 |
 +------------------+--------------------------+---------------+
 | Send an E-mail request to obtain a copy of my PGP key.      |
 +-------------------------------------------------------------+
 | "It is by caffeine alone I set my mind in motion.  It is by |
 |  cans of cola the thoughts aquire speed, the hands acquire  |
 |  shakes, the shakes become a warning.  It is by caffeine    |
 |  alone I set my mind in motion."                            |
 +-------------------------------------------------------------+


-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: noconv

iQEVAwUBPB9qpKVSqzlBVJbBAQGlWwf/d8uXUsdnXptSLxMRNN7+HqPLpruHeOPw
9CMJ1B5LeZfnAS5etvf3++BdMmV6/mUtw2Jo0SS/lW28hKgo6TU31rQNA1STusUl
GA1NGY0j+pYPAVVKnEeaPkMmryz3D1vKp9Yh9liVuQThxIwXOedqsmFE5WxER0Zm
tTknHIVv3OjOACftWhlQAebfNLFUL8XiPEos0zb7fBajUQd2rlk8cmSkZsUBB6D3
HclBs8NXrmyFePG5BKYUveNxEwWbxe4VMH4Ly2CjVvMJwD3ZF9Fqj2rZMmOfK3LG
2eD9gN6aOCwMWH1HoEHTXI+i7gxoH0BdsmnFgfamhDNB+lSTP8JVag==
=SoX8
-----END PGP SIGNATURE-----