Re: [Gcl-devel] More Code Cleanup...

[Camm Maguire]

Greetings!

Robert Alan Byer <address@hidden> writes:

> -----BEGIN PGP SIGNED MESSAGE-----
> 
> 
> In the following files...
> 
> gcl/gmp/assert.c
> gcl/gmp/randlc.c
> gcl/gmp/randraw.c
> gcl/gmp/mpn/generic/gcdext.c
> gcl/gmp/mpn/generic/tdiv_qr.c
> gcl/gmp/mpz/bin_uiui.c
> gcl/gmp/mpz/fac_ui.c
> gcl/gmp/mpz/fac_ui.c
> gcl/gmp/mpz/pprime_p.c
> gcl/gmp/mpz/root.c
> gcl/gmp/mpz.set_d.c
> 
> #include <stdlib.h> needs to be included to prevent the abort() function 
> from being implicitly declared.
> 

OK, First I'm going to try to eliminate these files :-)!  If I have to
keep them, will ammend as you so kindly note.

> Also, while compiling gcl/gmp/random.c under OpenVMS I got the following
> warning.
> 
>         return mrand48 () | (mrand48 () << 32);
>       .......................^
>       %CC-W-SHIFTCOUNT, In this statement, the shift count "32" is negative 
> or is 
>       greater than or equal to the promoted size of the operand 
> "mrand48(...)".
>       at line number 38 in file DISK$WORK:[TEST.GCL.GMP]URANDOM.H;1
> 
> and also got the same above error when compiling gcl/gmp/mpz/random.c
> 

This looks a little alarming.  It would appear that there is some
fixed size misconfiguration going on.  My 32 bit machine does not
select this version of random.c, so I don't have this code in my
build.  Perhaps you can see what type mrand48 is declared, and why the
code thinks it can shift it be 32 bits.  (It would seem that a 48bit
object would be a likely candidate.  But apparently the compiler does
not agree.)

> I have more code cleanup comming.
> 
> Currently, both Tru64 Alpha and OpenVMS Alpha build the libgmp library and 
> pass all the known GMP tests that are known to pass so I guess I'm on the
> right track.
> 
Great!

take care,

> 
>  +------------------+--------------------------+---------------+
>  | Robert Alan Byer | address@hidden | ICQ #65926579 |
>  +------------------+--------------------------+---------------+
>  | Send an E-mail request to obtain a copy of my PGP key.      |
>  +-------------------------------------------------------------+
>  | "It is by caffeine alone I set my mind in motion.  It is by |
>  |  cans of cola the thoughts aquire speed, the hands acquire  |
>  |  shakes, the shakes become a warning.  It is by caffeine    |
>  |  alone I set my mind in motion."                            |
>  +-------------------------------------------------------------+
> 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: 2.6.3ia
> Charset: noconv
> 
> iQEVAwUBPCCfCKVSqzlBVJbBAQEf0Af/fU6xXDZXu8RYh0sHqF1LCVn+9i7pmTew
> lFTOM6tc+pzKVh9qNHkBauNhQXh5xRfI0bGKgtdCLhP3SJVXcAiRsl0EeSQK9X+o
> MAgRjxiqbLQCBQjSRzafj9lkIRitOcOAGxpRYLJ7gIwOqwHorqcKvI6a194Lgxhu
> 2aAphiv+S5w+IaaNZTAto9sGVJ2Up/EY9oeGPj7uA57u0cxlEgQQHEMbKx96QUb5
> XbccukRNbUBX43m/0aLXCA8jL77H1x0cx+8+NRYHlT/tTkrw8ycBKWtxaYSKBG/v
> PnOoqTzOce0mZamBxUWU9r0F2f8Dzm8Aja2i5sUXwfFupiTgCl538Q==
> =btsG
> -----END PGP SIGNATURE-----
> 
> _______________________________________________
> Gcl-devel mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/gcl-devel
> 
> 

-- 
Camm Maguire                                            address@hidden
==========================================================================
"The earth is but one country, and mankind its citizens."  --  Baha'u'llah