Re: Segfault in change-class (was Re: [Gcl-devel] defgeneric method fix)

[Camm Maguire]

Greetings!  Paul, I think the following fixes this:

Index: error.c
===================================================================
RCS file: /cvsroot/gcl/gcl/o/error.c,v
retrieving revision 1.16
diff -u -r1.16 error.c
--- error.c     10 Jun 2003 13:28:11 -0000      1.16
+++ error.c     15 Jul 2003 17:13:24 -0000
@@ -238,6 +238,7 @@
   b[3]=null_string;
   b[4]=fmt_string;
   i=4;
+  n--;
   va_start(ap,fmt_string);
   while (--n)
     b[++i]=va_arg(ap,object);


To be committed shortly.  Please check it out.

Take care,

"Paul F. Dietz" <address@hidden> writes:

> I wrote:
> 
> > I am now getting a segfault when running the tests.  I've tracked
> > it down to a test in change-class.lsp, specifically change-class.error.5.
> > This test checks that an error is thrown if an attempt is made
> > to change an object into an instance of a built in class.  Here's
> > an example showing the bug:
> 
> This bug has nothing to do with change-class.  It occurs with any
> sequence of no applicable method errors from generic function calls:
> 
> GCL (GNU Common Lisp)  (2.5.3) Fri Jul 11 21:49:10 CDT 2003
> Licensed under GNU Library General Public License
> Dedicated to the memory of W. Schelter
> 
> Use (help) to get some basic information on how to use GCL.
> 
>  >(defgeneric f (x y))
> 
> #<compiled-closure F>
> 
>  >(loop for i from 0 do (format t "~A~%~A~%" i (multiple-value-list 
> (ignore-errors (f 1 2)))))
> 0
> (NIL Error in F [or a callee]: No matching method for the generic-function 
> #<compiled-closure F>,
> when called with arguments (1 2).)
> 1
> (NIL Error in PROGN [or a callee]: No matching method for the 
> generic-function #<compiled-closure F>,
> when called with arguments (1 2).)
> 2
> (NIL Error in PROGN [or a callee]: No matching method for the 
> generic-function #<compiled-closure F>,
> when called with arguments (1 2).)
> 3
> (NIL Error in PROGN [or a callee]: No matching method for the 
> generic-function #<compiled-closure F>,
> when called with arguments (1 2).)
> [...]
> 41
> (NIL Error in PROGN [or a callee]: No matching method for the 
> generic-function #<compiled-closure F>,
> when called with arguments (1 2).)
> 42
> (NIL Error in PROGN [or a callee]: No matching method for the 
> generic-function #<compiled-closure F>,
> when called with arguments (1 2).)
> 43
> (NIL Error in PROGN [or a callee]: No matching method for the 
> generic-function #<compiled-closure F>,
> when called with arguments (1 2).)
> 
> Unrecoverable error: Segmentation violation..
> 
> 
>       Paul
> 
> 
> 
> 
> _______________________________________________
> Gcl-devel mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/gcl-devel
> 
> 
> 

-- 
Camm Maguire                                            address@hidden
==========================================================================
"The earth is but one country, and mankind its citizens."  --  Baha'u'llah