Re: [gcmd-dev] Latest version 1.11 breaks building with gcc-9.3 inside core18 snap environment

[Uwe Scholz]

Am Fri, 27 Nov 2020 16:41:22 +0100 (CET) schrieb Stefan Czinczoll:
>
> Hi all,
> 
> right now I'm trying to create a working snap from gcmd (container format for 
> Ubuntu). This seems to be better supported than formerly targeted AppImage.
> 
> However, the current version 1.11.0 breaks building with core18 environment 
> (VM based on Ubuntu 18.04). Autotools are in use.
> 
> The error is shown below:
> 
> In file included from gnome-cmd-manage-profiles-dialog.h:27,
>                  from gnome-cmd-advrename-dialog.cc:37:
> gnome-cmd-edit-profile-dialog.h: In static member function ‘static void 
> GnomeCmd::ManageProfilesDialog<CONFIG, PROFILE, 
> COMPONENT>::edit_clicked_callback(GtkButton*, GtkWidget*) [with CONFIG = 
> GnomeCmdData::AdvrenameConfig; PROFILE = 
> GnomeCmdData::AdvrenameConfig::Profile; COMPONENT = 
> GnomeCmdAdvrenameProfileComponent]’:
> gnome-cmd-edit-profile-dialog.h:78:12: error: inlining failed in call to 
> ‘GnomeCmd::EditProfileDialog<PROFILE, 
> COMPONENT>::EditProfileDialog(GtkWindow*, PROFILE&, const char*) [with 
> PROFILE = GnomeCmdData::AdvrenameConfig::Profile; COMPONENT = 
> GnomeCmdAdvrenameProfileComponent]’: --param max-inline-insns-single limit 
> reached [-Werror=inline]
>    78 |     inline 
> EditProfileDialog<PROFILE,COMPONENT>::EditProfileDialog(GtkWindow *parent, 
> PROFILE &profile, const char *id):  help_id(id)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from gnome-cmd-advrename-dialog.cc:37:
> gnome-cmd-manage-profiles-dialog.h:220:13: note: called from here
>   220 |             if (GnomeCmd::EditProfileDialog<PROFILE,COMPONENT> 
> (GTK_WINDOW (dialog), p, help_id))
>       |             ^~
> cc1plus: all warnings being treated as errors
> Makefile:548: recipe for target 'gnome-cmd-advrename-dialog.o' failed
> make[3]: *** [gnome-cmd-advrename-dialog.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> mv -f .deps/gnome-cmd-chmod-dialog.Tpo .deps/gnome-cmd-chmod-dialog.Po
> make[3]: Leaving directory '/root/parts/gcmd/build/src/dialogs'
> Makefile:834: recipe for target 'all-recursive' failed
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory '/root/parts/gcmd/build/src'
> Makefile:540: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/root/parts/gcmd/build'
> Makefile:470: recipe for target 'all' failed
> make: *** [all] Error 2
> Failed to run 'make -j2' for 'gcmd': Exited with code 2.

Hm, hmmm. You have activated that all warnings are treated as errors.
Can you try "make -Wno-error"?

Probably that would do it.

I actually don't know why this is activated in your case. For me these
warnings are just shown as warnings when compiling the master branch.

But it is better to work with the "stable" gcmd-1.10 branch when you
want to create a snap pack. The master branch is the "unstable"
development branch, that is why warnings are shown in that branch when
compiling the sources.

Question: How did you get the sources of Gnome commander? With git clone?

Best
Uwe