Re: [gcmd-usr] multi-thread problem on delete

[Marcus Bjurman]

On Sun, 2003-03-23 at 22:07, Marcus Bjurman wrote:
> Also since the call to 'gnome_cmd_dir_file_deleted' in 
> gnome-cmd-delete-dialog.c:177 
> already is included in a thread_enter/leave block I don't understand how your 
> patch can make any difference.
> 
> Maybe the issue is that the call to 'gnome_cmd_dir_file_deleted' emits a 
> signal which makes the file-list remove the file. It could be possible that
> because of this the threads_enter/leave block is not effective when the 
> file-list tries to remove the row.

Hi again Dimitri,

Just forget what I said in the previous mail, it was not really correct.
Since you're running with fam it's not the call to
gnome_cmd_dir_file_deleted in the gnome-cmd-delete-dialog.c file that
causes the signal to be emitted but rather it is the on_fam_event
function in gnome-cmd-fam.c.

Could you try to wrap the calls to the gnome_cmd_dir_file_* functions in
gnome-cmd-fam.c with thread_enter/leaves calls instead? I think that
would be a better and cleaner solution. As it will cover all cases of
files deleted, modified and created.

/Marcus