[Gforge-commits] gforge/www/include BaseLanguage.class,1.12,1.13

[tom]

Update of /cvsroot/gforge/gforge/www/include
In directory db.perdue.net:/tmp/cvs-serv15460/www/include

Modified Files:
        BaseLanguage.class 
Log Message:
SQL optimization: Replaced 'select *' in BaseLanguage.class with explicit 
column names.  Also added some PHPDoc.

Index: BaseLanguage.class
===================================================================
RCS file: /cvsroot/gforge/gforge/www/include/BaseLanguage.class,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -d -r1.12 -r1.13
--- BaseLanguage.class  16 Jan 2004 10:35:14 -0000      1.12
+++ BaseLanguage.class  26 Feb 2004 21:42:49 -0000      1.13
@@ -336,12 +336,18 @@
 
 }
 
+       /**
+        * language_code_to_result - get the classname for a language id
+        * 
+        * @param string $alang A language ID
+        * @return db_result A database result set containing one field - the 
+        * language class name.  TODO: We could probably simplify things a
+        * bit by making this function just return the class name, not a DB 
result.
+        */
 function language_code_to_result($alang) {
        global $cookie_language_id;
 
        /*
-
-
                Determine which language file to use
 
                It depends on whether the user has set a cookie or not using
@@ -352,14 +358,13 @@
                else check for cookie and use that value if valid
                if no cookie check browser preference and use that language if 
valid
                else just use english
-
        */
 
        if ($cookie_language_id) {
                $lang=$cookie_language_id;
-               $res=db_query("select * from supported_languages where 
language_id='$lang'");
+               $res=db_query("select classname from supported_languages where 
language_id='$lang'");
                if (!$res || db_numrows($res) < 1) {
-                       return db_query("select * from supported_languages 
where language_id='1'"); // default to english
+                       return db_query("select classname from 
supported_languages where language_id='1'"); // default to english
                } else {
                        return $res;
                }
@@ -367,7 +372,7 @@
                $ary = explode(',', str_replace(' ', '', $alang)); // delete 
space and split
                for( $i=0; $i<sizeof($ary); $i++){
                        $lang_code = ereg_replace(';.*', '', $ary[$i]); // 
remove ;q=0.x
-                       $res = db_query("select * from supported_languages 
where language_code = '$lang_code'");
+                       $res = db_query("select classname from 
supported_languages where language_code = '$lang_code'");
                        if (db_numrows($res) > 0) {
                                return $res;
                        }
@@ -375,7 +380,7 @@
                        // If so, try to strip it and look for for main 
language only
                        if (strstr($lang_code, '-')) {
                                $lang_code = substr($lang_code, 0, 2);
-                               $res = db_query("select * from 
supported_languages where language_code = '$lang_code'");
+                               $res = db_query("select classname from 
supported_languages where language_code = '$lang_code'");
                                if (db_numrows($res) > 0) {
                                        return $res;
                                }
@@ -385,4 +390,4 @@
        }
 }
 
-?>
\ No newline at end of file
+?>