[Gforge-commits] gforge/common/include Permission.class,1.4,1.5

[tom]

Update of /cvsroot/gforge/gforge/common/include
In directory db.perdue.net:/tmp/cvs-serv29650/common/include

Modified Files:
        Permission.class 
Log Message:
Replaced a 'select *' with a 'select count(*)'

Index: Permission.class
===================================================================
RCS file: /cvsroot/gforge/gforge/common/include/Permission.class,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- Permission.class    18 Feb 2004 09:18:22 -0000      1.4
+++ Permission.class    12 Mar 2004 19:08:54 -0000      1.5
@@ -208,22 +208,18 @@
         *  @return     boolean is_super_user.
         */
        function isSuperUser() {
-               if (isset($this->is_site_admin)) {
-                       return $this->is_site_admin;
-               }
+               if (isset($this->is_site_admin)) {
+                       return $this->is_site_admin;
+               }
 
-               $res = db_query("SELECT * FROM user_group
+               $res = db_query("SELECT count(*) FROM user_group
                        WHERE user_id='". $this->User->getID() ."'
                        AND group_id='1'
                        AND admin_flags='A'");
-
-               if (!$res || db_numrows($res) < 1) {
-                       $this->is_site_admin = false;
-               } else {
-                       $this->is_site_admin = true;
-               }
-
+               $row_count = db_fetch_array($result);
+               $this->is_site_admin = $res && $row_count['count'] > 0;
                db_free_result($res);
+
                return $this->is_site_admin;
        }