[Gforge-commits] gforge/common/include User.class,1.30,1.31

[tom]

Update of /cvsroot/gforge/gforge/common/include
In directory db.perdue.net:/tmp/cvs-serv24097/common/include

Modified Files:
        User.class 
Log Message:
SQL Optimization: replaced a 'select *' with a 'select count(*)'

Index: User.class
===================================================================
RCS file: /cvsroot/gforge/gforge/common/include/User.class,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -d -r1.30 -r1.31
--- User.class  25 Mar 2004 23:23:59 -0000      1.30
+++ User.class  8 Apr 2004 20:03:29 -0000       1.31
@@ -964,16 +964,15 @@
        function setLoggedIn($val=true) {
                $this->is_logged_in=$val;
                if ($val) {
-                       //if this is the logged in user - 
-                       //see if they are a super user
-                       $sql="SELECT * FROM user_group ".
-                               "WHERE user_id='". $this->getID() ."' AND 
group_id='1' AND admin_flags='A'";
+                       //if this is the logged in user, see if they are a 
super user
+                       $sql="SELECT count(*) FROM user_group WHERE user_id='". 
$this->getID() ."' AND group_id='1' AND admin_flags='A'";
                        $result=db_query($sql);
-                       if (!$result || db_numrows($result) < 1) {
+                       if (!$result) {
                                $this->is_super_user=false;
-                       } else {
-                               $this->is_super_user=true;
+                               return;
                        }
+                       $row_count = db_fetch_array($result);
+                       $this->is_super_user = ($row_count['count'] > 0);
                }
        }