[Gforge-commits] gforge/common/tracker ArtifactFile.class, 1.9, 1.10 ArtifactType.class, 1.23, 1.24

[gsmet]

Update of /cvsroot/gforge/gforge/common/tracker
In directory db.perdue.net:/tmp/cvs-serv24533/common/tracker

Modified Files:
        ArtifactFile.class ArtifactType.class 
Log Message:
Fixed [#905] Incorrect DB transaction handling in ArtifactType.class

Index: ArtifactFile.class
===================================================================
RCS file: /cvsroot/gforge/gforge/common/tracker/ArtifactFile.class,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -d -r1.9 -r1.10
--- ArtifactFile.class  18 Feb 2004 09:18:23 -0000      1.9
+++ ArtifactFile.class  23 Sep 2004 22:03:36 -0000      1.10
@@ -118,14 +118,14 @@
                        $filesize = strlen($bin_data);
                }
 
+               db_begin();
+
                $res=db_query("INSERT INTO artifact_file
                        
(artifact_id,description,bin_data,filename,filesize,filetype,adddate,submitted_by)
                        VALUES 
                        ('".$this->Artifact->getID()."','$description','". 
base64_encode($bin_data) ."','$filename',
                        '$filesize','$filetype','". time() ."','$userid')"); 
 
-               db_begin();
-
                $id=db_insertid($res,'artifact_file','id');
 
                if (!$res || !$id) {

Index: ArtifactType.class
===================================================================
RCS file: /cvsroot/gforge/gforge/common/tracker/ArtifactType.class,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -d -r1.23 -r1.24
--- ArtifactType.class  26 Aug 2004 15:32:06 -0000      1.23
+++ ArtifactType.class  23 Sep 2004 22:03:36 -0000      1.24
@@ -255,10 +255,11 @@
                        '".htmlspecialchars($submit_instructions)."',
                        '".htmlspecialchars($browse_instructions)."',
                        '$datatype')";
-               //echo $sql;
+               
+               db_begin();
+               
                $res = db_query($sql);
 
-               db_begin();
                $id = 
db_insertid($res,'artifact_group_list','group_artifact_id');
                
                if (!$res || !$id) {