gforge-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gforge-commits] gforge-plugin-scmsvn/include SVNPlugin.class, 1.3, 1.4


From: tperdue
Subject: [Gforge-commits] gforge-plugin-scmsvn/include SVNPlugin.class, 1.3, 1.4
Date: Thu, 30 Sep 2004 11:00:04 -0500

Update of /cvsroot/gforge/gforge-plugin-scmsvn/include
In directory db.perdue.net:/var/www/gforge/plugins/scmsvn/include

Modified Files:
        SVNPlugin.class 
Log Message:
fixing more critical bugs

Index: SVNPlugin.class
===================================================================
RCS file: /cvsroot/gforge/gforge-plugin-scmsvn/include/SVNPlugin.class,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- SVNPlugin.class     29 Sep 2004 19:52:02 -0000      1.3
+++ SVNPlugin.class     30 Sep 2004 16:00:01 -0000      1.4
@@ -2,7 +2,7 @@
 /** Subversion plugin for Gforge
  * Copyright 2003 Roland Mas <address@hidden>
  * Copyright 2004 Roland Mas <address@hidden> 
- *                The Gforge Group, LLC <http://gforgegroup.com/>
+ *                             The Gforge Group, LLC <http://gforgegroup.com/>
  * Based on the CVS plugin, which was derived from Gforge, which was
  * derived from Sourceforge
  *
@@ -36,7 +36,7 @@
                $this->hooks[] = "group_approved";
                $this->hooks[] = "scm_plugin";
 
-                require_once('/etc/gforge/plugins/scmsvn/config.php') ;
+               require_once('/etc/gforge/plugins/scmsvn/config.php') ;
                
                $this->default_svn_server = $default_svn_server ;
                $this->this_server = $this_server ;
@@ -84,8 +84,8 @@
 // ************************************************
                        
                 print '<h2>Subversion</h2>
-                               <p>Documentation for Subversion (sometimes 
referred to as "SVN") is available <a 
href="http://svnbook.red-bean.com/";>here</a>.
-                                </p>' ;
+                                               <p>Documentation for Subversion 
(sometimes referred to as "SVN") is available <a 
href="http://svnbook.red-bean.com/";>here</a>.
+                                                               </p>' ;
 
 
                        if($this->svn_single_host) {
@@ -105,9 +105,9 @@
         if ($this->UsesAnonSVN ($group_id)) {
                 // echo $Language->getText('scm_index', 'anoncvs');
                 print "<b>Anonymous Subversion Access</b>
-                               <p>
-                               <tt>svn checkout svn://" . 
$this->GetGroupServer($group_id) . "/".$project->getUnixName()."</tt>
-                                </p>" ;
+                                               <p>
+                                               <tt>svn checkout svn://" . 
$this->GetGroupServer($group_id) . "/".$project->getUnixName()."</tt>
+                                                               </p>" ;
         }
 
 // ############################ developer access
@@ -150,7 +150,7 @@
 
        echo "<p><a href=\"http://"; . $this->GetGroupServer($group_id) . 
"/plugins/scmsvn/cgi-bin/viewcvs.cgi?root=".$project->getUnixName()."\">Browse</a>
 SVN tree</p>" ;
 
-       echo $HTML->boxBottom();
+       echo $HTML->boxBottom();
 }
 
 ?>
@@ -203,7 +203,7 @@
 <input type="checkbox" name="scmsvn_enable_anon_svn" value="1" <?php if 
($this->UsesAnonSVN($params['group_id'])) {print '"checked"';} ?>> 
<strong>Allow anonymous Subversion</strong><br>
 <input type="text" name="scmsvn_svn_server" value="<?php echo 
$this->GetGroupServer ($params['group_id']) ?>"> <strong>Subversion 
server</strong><br><br>
 <?php
-                                                                               
                                      }
+                                                                               
                                          }
 
        function display_stats ($params) {
                global $Language ;
@@ -213,7 +213,7 @@
                        FROM plugin_scmsvn_stats
                        WHERE group_id='$group_id'");
                $commit_num = db_result($result,0,0);
-               $add_num    = db_result($result,0,1);
+               $add_num        = db_result($result,0,1);
                if (!$commit_num) {
                        $commit_num=0;
                }
@@ -224,17 +224,22 @@
                
        }
        
-        function group_approved ($params) {
-                $group_id = $params['group_id'] ;
-               
-                $project =& group_get_object($group_id);
+       function group_approved ($params) {
+               $group_id = $params['group_id'] ;
                
-                if ($this->enabled_by_default) {
-                        $group->setPluginUse("scmsvn", 1) ;
-                } else {
-                        $group->setPluginUse("scmsvn", 0) ;
-                }
-        }
+               $project =& group_get_object($group_id);
+               if (!$project || !is_object($project)) {
+                       return false;
+               } elseif ($project->isError()) {
+                       return false;
+               }
+               if ($this->enabled_by_default) {
+                       $project->setPluginUse("scmsvn", 1) ;
+               } else {
+                       $project->setPluginUse("scmsvn", 0) ;
+               }
+               return true;
+       }
        
        function GetDefaultServer () {
                return $this->default_svn_server ;





reply via email to

[Prev in Thread] Current Thread [Next in Thread]