[Gforge-commits] gforge/deb-specific db-upgrade.pl,1.59,1.60

[cbayle]

Update of /cvsroot/gforge/gforge/deb-specific
In directory db.perdue.net:/tmp/cvs-serv30531/deb-specific

Modified Files:
        db-upgrade.pl 
Log Message:
Better test of system call return code


Index: db-upgrade.pl
===================================================================
RCS file: /cvsroot/gforge/gforge/deb-specific/db-upgrade.pl,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -d -r1.59 -r1.60
--- db-upgrade.pl       23 Sep 2004 21:48:27 -0000      1.59
+++ db-upgrade.pl       30 Sep 2004 21:23:18 -0000      1.60
@@ -1615,26 +1615,22 @@
     $target = "3.3.0-2+1" ;
     if (&is_lesser ($version, $target)) {
         &debug ("Upgrading with migrateforum.php") ;
-       if (system("/usr/lib/gforge/db/20040826_migrateforum.php -d 
include_path=/usr/share/gforge/:/usr/share/gforge/www/include")){
+       system("/usr/lib/gforge/db/20040826_migrateforum.php -d 
include_path=/usr/share/gforge/:/usr/share/gforge/www/include") == 0 
+       or die "system call of 20040826_migrateforum.php failed: $?" ;
         &update_db_version ($target) ;
         &debug ("Committing.") ;
         $dbh->commit () ;
-       } else {
-               exit 1;
-       }
     }
 
     $version = &get_db_version ;
     $target = "3.3.0-2+2" ;
     if (&is_lesser ($version, $target)) {
         &debug ("Upgrading with migraterbac.php") ;
-       if (system("/usr/lib/gforge/db/20040826_migraterbac.php -d 
include_path=/usr/share/gforge/:/usr/share/gforge/www/include")){
+       system("/usr/lib/gforge/db/20040826_migraterbac.php -d 
include_path=/usr/share/gforge/:/usr/share/gforge/www/include") == 0
+       or die "system call of 20040826_migraterbac.php failed: $?" ;
         &update_db_version ($target) ;
         &debug ("Committing.") ;
         $dbh->commit () ;
-       } else {
-               exit 1;
-       }
     }