Re: [Gluster-devel] [PATCH 3/4] mod_glusterfs/apache/2.2: Added -L$(libdir) to ${APXS} args.

[Raghavendra G]

Hi Matsuu,

Thanks for submitting a patch.

The reason why we did not add $(libdir) to the list of directories being searched for libglusterfsclient.so is that mod_glusterfs will always be in sync with the libglusterfsclient that is being built along with it but there is no guarantee that it will be in sync with the already installed version (as specified by adding -L$(libdir)).

Is there any other reason for adding -L$(libdir) option?

regards,

On Fri, May 15, 2009 at 6:54 PM, <address@hidden> wrote:

From: MATSUU Takuto <address@hidden>

---
 mod_glusterfs/apache/2.2/src/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mod_glusterfs/apache/2.2/src/Makefile.am b/mod_glusterfs/apache/2.2/src/Makefile.am
index 1e8f3a3..b2b73dd 100644
--- a/mod_glusterfs/apache/2.2/src/Makefile.am
+++ b/mod_glusterfs/apache/2.2/src/Makefile.am
@@ -7,7 +7,7 @@ all: mod_glusterfs.so

 mod_glusterfs.so: $(top_srcdir)/mod_glusterfs/apache/2.2/src/mod_glusterfs.c $(top_builddir)/libglusterfsclient/src/libglusterfsclient.la
       ln -sf $(top_srcdir)/mod_glusterfs/apache/2.2/src/mod_glusterfs.c $(top_builddir)/mod_glusterfs/apache/2.2/src/mod_glusterfs-build.c
-       $(APXS) -c -o mod_glusterfs.la -Wc,-g3 -Wc,-O0 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -I$(top_srcdir)/libglusterfsclient/src -L$(top_builddir)/libglusterfsclient/src/.libs/ -lglusterfsclient mod_glusterfs-build.c
+       $(APXS) -c -o mod_glusterfs.la -Wc,-g3 -Wc,-O0 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -I$(top_srcdir)/libglusterfsclient/src -L$(libdir) -L$(top_builddir)/libglusterfsclient/src/.libs/ -lglusterfsclient mod_glusterfs-build.c
       -ln -sf .libs/mod_glusterfs.so mod_glusterfs.so

 $(top_builddir)/libglusterfsclient/src/libglusterfsclient.la:
--
1.6.3



_______________________________________________
Gluster-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/gluster-devel

-- 
Raghavendra G