[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gluster-devel] [PATCH BUG:3085] Make backupvolfile-server option ac
|
From: |
Jeff Darcy |
|
Subject: |
Re: [Gluster-devel] [PATCH BUG:3085] Make backupvolfile-server option actually work. |
|
Date: |
Mon, 27 Jun 2011 11:20:59 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc11 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 06/27/2011 11:16 AM, Devon Miller wrote:
> I was thinking more of the case where no backup server is
> configured. If the primary server fails, and a backup is not defined,
> then found=0 and err=0. So, the script will eventually exit with a 0
> when it really should have exited with a 1.
You're right, the code doesn't fix that (pre-existing) hole. We should
really set err=1 before we check for the definition of a backup server.
Thanks!