Re: [Gluster-devel] [PATCH BUG:2999 1/1] Add SSL and multi-threading to socket transport

[Emmanuel Dreyfus]

On Mon, Jul 18, 2011 at 02:41:59PM +0000, Emmanuel Dreyfus wrote:
> Sorry, I got the subject from the wrong message (not sure how I managed to do 
> that). I repost.
> 
> On Mon, Jul 18, 2011 at 02:39:49PM +0000, Emmanuel Dreyfus wrote:
> > Hi
> > 
> > I am still unable to use your patch, but I spoted two bugs
> > 
> > > + if (server) {
> > > +         ret = SSL_accept(priv->ssl_ssl);
> > > + }
> > > + else {
> > > +         ret = SSL_connect(priv->ssl_ssl);
> > > + }
> > 
> > Here you should  use SSL_get_error() and check for various errors
> > that require SSL_accept/SSL_connect to be restarted. For instance, 
> > I could not get openssl s_client to show the server certificate if I do 
> > not restart on SSL_ERROR_WANT_READ. The connexion just closed immediatly,
> > and kernel trace show the SSL socket returns EAGAIN on a read(2°.
> > 
> > > +socket_poller (void *ctx)
> > > +{
> > > +        rpc_transport_t  *this = ctx;
> > > +        socket_private_t *priv = this->private;
> > > + struct pollfd     pfd[2] = {{0,},};
> > > + gf_boolean_t      to_write = _gf_false;
> > > + int               ret = 0;
> > > + int               orig_gen;
> > 
> > orig_gen may be used uninitialized.
> > -- 
> > Emmanuel Dreyfus
> > address@hidden
> 
> -- 
> Emmanuel Dreyfus
> address@hidden

-- 
Emmanuel Dreyfus
address@hidden