[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gluster-devel] usage

From: Jeff Darcy
Subject: Re: [Gluster-devel] usage
Date: Fri, 16 Dec 2011 14:05:09 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16

On 12/16/2011 09:23 AM, Emmanuel Dreyfus wrote:
> I wanted to add an updated patchset to,796
> but gerrit shows identical patchset 1 and 2. How I am supposed to do?
> here is what I did:
> git clone 
> cp -r glusterfs getgroups && cd getgroups
> git branch getgroups
> vi xlator/mount/fuse/src/fuse-helper.c
> commit -s xlator/mount/fuse/src/fuse-helper.c
> ./                                      -> this produced patchset 1
> vi xlator/mount/fuse/src/fuse-helper.c                -> update for patchset 2
> commit -s xlator/mount/fuse/src/fuse-helper.c
> ./                                      -> this produced patchset 2

It seems odd that it created a new patchset at all.  Normally you're supposed
to use the "--amend" flag on commit, to modify the existing HEAD instead of
creating a new one.  What I would have expected the above to result in a new
Gerrit review request dependent on the old request, not a new patchset on the
old request, but maybe there's more git silliness here than meets the eye.

Wait, what am I saying?  This is git, so of course it's behaving irrationally.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]