Re: [Gluster-devel] Fwd: Re: Rejected NetBSD patches

[Kaleb S. KEITHLEY]

On 04/30/2012 03:32 PM, Emmanuel Dreyfus wrote:
> Kaleb S. KEITHLEY<address@hidden>  wrote:
>
> > Dunno. My inclination is to try and make a thing correct for as many
> > things as I know about without regard to anything else. Or turn it
> > around and make if #if defined(GF_BSD_HOST_OS) ||
> > defined(GF_DARWIN_HOST_OS), Either way, please use the appropriate
> > GLUSTER GF_*_HOST_OS feature test.
>
> Well, before I can do this, there is a need for a massive GF_BSD_HOST_OS
> into GF_FREEBSD_HOST_OS and GF_NETBSD_HOST_OS.

I don't agree. I don't see the need to do that at all.

Frankly I'm not sure why we even have GF_DARWIN_HOST_OS.

I haven't seen anything so far that needs to discriminate between NetBSD 
and FreeBSD, but if we come across one, we can use __NetBSD__ and 
__FreeBSD__ inside GF_BSD_HOST_OS.

--

Kaleb