Re: [Gluster-devel] [PATCH v5 0/4] Qemu/Gluster support in Libvirt

[Harsh Bora]

On 11/27/2012 03:01 PM, Jiri Denemark wrote:
> On Thu, Nov 22, 2012 at 23:40:37 +0530, Harsh Prateek Bora wrote:
> > Changelog:
> >
> > v5:
> > - Separated initialization of new host members for nbd, rbd, sheepdog
> >    in a separate patch [Patch 3/4]
> > - Fixed tests for appropriate args to DO_TEST
> > - Code cleanups for squashing pointer incrememnts into single line.
> >
> > v4:
> > - Addressed review comment by Jiri on v3 updated series.
> >
> > v3 updated:
> > - Fix other network backends (nbd, rbd, sheepdog) to initialize new members
> >    (transport, socket) of _virDomainDiskHostDef appropriately so that garbage
> >    values doesnt break the argv2xml tests.
> >
> > v3:
> > - RNG schema updated as required for unix transport [Paolo]
> > - introduced another new attribute 'socket' for unix transport [Paolo]
> > - Uses virURIFormat and virURIParse for URI parsing. [danpb]
> > - updated documentation as required. [Jirka]
> >
> > v2:
> > - Addressed review comments by Jiri
> > - Updated patcheset as per new URI spec
> > Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg05199.html
> >
> > v1:
> > - Initial prototype
>
> OK, I fixed the remaining small issues and pushed this series. Thanks for your
> work.

Hi Jirka,
Thanks for the detailed reviews and pushing the series with required 
fixes. It was a true pleasure to work with you and everyone involved.

regards,
Harsh

> Jirka