|
From: | Krishnan Parthasarathi |
Subject: | Re: [Gluster-devel] catching unitialized structures |
Date: | Tue, 30 Apr 2013 10:44:59 +0530 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 04/29/2013 10:44 PM, Emmanuel Dreyfus wrote:
On Mon, Apr 29, 2013 at 05:01:46PM +0000, Emmanuel Dreyfus wrote:I found an uninitialized mutex and I am tracking another one.In xlators/mgmt/glusterd/src:gd_lock_op_phase() gd_syncargs_init() is not called, whereas it is called at other places to initialize args. Is it correct?
It is correct (and intentional). gd_lock_op_phase and gd_unlock_op_phase don't use args->dict, so don't use the args->lock_dict to protect it's access. ~krish
[Prev in Thread] | Current Thread | [Next in Thread] |