[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gluster-devel] [PATCH 3/3 v4] vfs_glusterfs: Samba VFS module for g
|
From: |
Andreas Schneider |
|
Subject: |
Re: [Gluster-devel] [PATCH 3/3 v4] vfs_glusterfs: Samba VFS module for glusterfs |
|
Date: |
Fri, 24 May 2013 10:03:37 +0200 |
|
User-agent: |
KMail/4.10.2 (Linux/3.8.11-200.fc18.x86_64; KDE/4.10.2; x86_64; ; ) |
On Friday, May 24, 2013 14:31:33 Andrew Bartlett wrote:
> On Thu, 2013-05-23 at 22:30 -0400, Anand Avati wrote:
> > static char *vfs_gluster_getwd(struct vfs_handle_struct *handle)
> > +{
> > + char *cwd;
> > + char *ret;
> > +
> > + cwd = TALLOC_ZERO(NULL, PATH_MAX+1);
> > + if (!cwd)
> > + return NULL;
> > +
> > + ret = glfs_getcwd(handle->data, cwd, PATH_MAX);
> > + if (!ret)
> > + TALLOC_FREE(cwd);
> > + return ret;
> > +}
It is not a blocker for the patch but it would be nice if you could apply our
coding styles in future. See
https://blog.cryptomilk.org/2013/03/28/writing-and-reading-code/
Thanks,
-- andreas