gluster-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gluster-devel] [PATCH v9] vfs_glusterfs: Samba VFS module for glust


From: Anand Avati
Subject: Re: [Gluster-devel] [PATCH v9] vfs_glusterfs: Samba VFS module for glusterfs
Date: Wed, 29 May 2013 14:00:55 -0700
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6

On 5/29/13 1:58 PM, Jeremy Allison wrote:
On Wed, May 29, 2013 at 01:54:20PM -0700, Anand Avati wrote:

3. In our test case the fd number returned by vfs_gluster for the
initial open file _was_ 0. That dirfd() condition needs a fix, I
think?

Yep. That's why I fixed it in master and 4.0.x, it already came up in
a breakage of a different vfs module that used the same trick.

I don't know if the master branch has equivalent code elsewhere,
couldn't find it easily..

Oh now I understand, that's the broken code I fixed in master :-).
It's already been back-ported to 4.0.x.

You'll need to back port the dirfd removal fixes from 4.0.x to
3.6.x in order for this to wotk.


Phew! OK. That was a twisted rediscovery :-)

So that means v9 is still good as it is submitted against master. Merge please? :-)

Avati





reply via email to

[Prev in Thread] Current Thread [Next in Thread]