Re: [Gluster-devel] Warning in logging.c

[Harshavardhana]

Gluster default logging can be enabled by creating  `/var/lib/glusterd/logger.conf` and restarting Gluster services. 

But i would vote for a much better way to handle this in more document friendly manner - since creating a file and restarting is obscure and prone to errors. Avati's idea is perhaps even more valid syslog should be optional based on logger.conf and a parameter in it saying.

/var/lib/glusterd/logger.conf:

logging_style = syslog

or

/var/lib/glusterd/logger.conf:

logging_style = glusterfs

Regards

--

Harsha

On Sun, Jul 28, 2013 at 9:17 PM, Anand Avati <address@hidden> wrote:

We should also address the fact that in master branch, by default, gluster logs go empty -- which is an annoying new default behavior, significantly difference from how glusterfs has behaved for years. The change to the new rsyslog based model must be more gradual (start by providing an option to use rsyslog initially, move some types of logs - those which makes sense to user rather than developer - there by default later, and finally fully make rsyslog by default, by taking user feedback in each step. The current cut over is too drastic, only getting it in json format (which is not as convenient as the old format for an admin to "see") and a lot of admin tools why rely upon the logs to be in /var/log/glusterfs in the well-known format are now broken.

Bala - can you please submit a patch to revert just the default behavior (i.e, make rsyslog optional rather than default) first, and propose a plan for how to start moving things over to rsyslog more gradually? Let's at least have a separate discussion thread around this.

Thanks,

Avati

On Sun, Jul 28, 2013 at 9:09 PM, Vijay Bellur <address@hidden> wrote:

Hi Bala,

After the syslog improvements got merged, the following warning is being seen:

../../../libglusterfs/src/logging.c: In function 'gf_syslog':
../../../libglusterfs/src/logging.c:281:21: warning: variable 'p' set but not used [-Wunused-but-set-variable]

Can you please address this?

Thanks,
Vijay

_______________________________________________
Gluster-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/gluster-devel

_______________________________________________
Gluster-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/gluster-devel