gluster-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gluster-devel] Change in glusterfs[release-3.4]: call-stub: interna


From: Anand Avati
Subject: Re: [Gluster-devel] Change in glusterfs[release-3.4]: call-stub: internal refactor
Date: Thu, 05 Sep 2013 07:22:44 -0700
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8

On 9/5/13 6:27 AM, Vijay Bellur (Code Review) wrote:
Vijay Bellur has submitted this change and it was merged.

Change subject: call-stub: internal refactor
......................................................................


call-stub: internal refactor

- re-structure members of call_stub_t with new simpler layout
- easier to inspect call_stub_t contents in gdb now
- fix a bunch of double unrefs and double frees in cbk stub
- change all STACK_UNWIND to STACK_UNWIND_STRICT and thereby fixed
   a lot of bad params
- implement new API call_unwind_error() which can even be called on
   fop_XXX_stub(), and not necessarily fop_XXX_cbk_stub()

Change-Id: Idf979f14d46256af0afb9658915cc79de157b2d7
BUG: 846240
Signed-off-by: Anand Avati <address@hidden>
Reviewed-on: http://review.gluster.org/4520
Tested-by: Gluster Build System <address@hidden>
Reviewed-by: Jeff Darcy <address@hidden>
Reviewed-on: http://review.gluster.org/5820
Reviewed-by: Raghavendra Bhat <address@hidden>
---
M libglusterfs/src/call-stub.c
M libglusterfs/src/call-stub.h
M xlators/performance/write-behind/src/write-behind.c
3 files changed, 1,104 insertions(+), 2,994 deletions(-)

Approvals:
   Raghavendra Bhat: Looks good to me, approved
   Gluster Build System: Verified




Note that this backported patch had a bug in master and there was a follow-up patch http://review.gluster.org/4564. This needs to be backported too.

Avati




reply via email to

[Prev in Thread] Current Thread [Next in Thread]