Re: [Gluster-devel] glfs_readdir_r is painful

[Anand Avati]

On Wed, Oct 30, 2013 at 3:54 PM, Eric Blake <address@hidden> wrote:

> Hmm, I don't think so.. strncpy of 255 bytes on to a buffer guaranteed to
> be 256 or higher and also guaranteed to be 0-memset'ed cannot return an
> invalid file name. No?

The fact that your internal glfs_readdir buffer is memset means you are
safe there for a 255-byte filename; but that safety does not extend to
glfs_readdir_r for a user buffer.

Right! Fixed - http://review.gluster.org/#/c/6201/2