Re: [Gluster-devel] Fwd: Snapshot feature design review

[Rajesh Joseph]

Hi Vijay,

The hyphenated options are used to distinguish multiple optional options used 
in snapshot commands.
One case you already mention which is of Consistency Group. There are some more 
cases.
e.g. In snapshot create we have to provide the volume name, snapshot name and 
description. Both 
snapshot name and description are optional fields.

So to handle such cases we have to replace most of the hyphenated options with 
keywords, e.g. "consistency-group",
"snap-name", etc. Do you see any issues especially usability if hyphenated 
options are replaced with keywords?

All suggestions are welcome.

Thanks & Regards,
Rajesh

----- Original Message -----
From: "Vijay Bellur" <address@hidden>
To: "Nagaprasad Sathyanarayana" <address@hidden>, address@hidden
Cc: "Rajesh Joseph" <address@hidden>
Sent: Thursday, December 19, 2013 9:28:40 AM
Subject: Re: [Gluster-devel] Fwd: Snapshot feature design review

On 10/17/2013 09:52 PM, Nagaprasad Sathyanarayana wrote:
>
>>>
>>> Hi All,
>>>
>>> The design document has been updated, and we have tried to address
>>> all the review comments and design issues to the best of our ability.
>>>
>>> Please review the design and the document when possible.
>>>
>>> The design document can be found @
>>> https://forge.gluster.org/snapshot/pages/Home
>>>
>>> Please feel free to critique/comment.


Belated feedback on the CLI. CLI does seem to have a lot of hyphen/dash 
options. This is something that we have avoided in gluster so far. 
Conforming to the same design principle would be nice to have.

The only reason why a hyphenated option seems necessary is due to the 
consistency groups. It would be better to treat consistency-group as a 
first class entity and have a separate mechanism to define that. For e.g.:

#gluster consistency-group create <name>

#gluster consistency-group add <vol1,vol2,...volN>

#gluster consistency-group del <vol1...volN>


Once this is accomplished, we can avoid using the hyphenated options and 
distinguish between single volume snapshots and consistency-group 
snapshots by using a keyword for consistency groups.

For e.g., creation of a snapshot can be structured as:

#gluster snapshot create [consistency-group] <name> [<description>]

Other snapshot commands can be structured on similar lines.

Thoughts?

Thanks,
Vijay