|
From: | Udo Giacomozzi |
Subject: | Re: [Gnash-commit] gnash ChangeLog server/button_character_instanc... |
Date: | Thu, 19 Apr 2007 19:47:51 +0200 |
UG> http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2938&r2=1.2939 UG> http://cvs.savannah.gnu.org/viewcvs/gnash/server/button_character_instance.cpp?cvsroot=gnash&r1=1.43&r2=1.44 UG> http://cvs.savannah.gnu.org/viewcvs/gnash/server/character.cpp?cvsroot=gnash&r1=1.36&r2=1.37 UG> http://cvs.savannah.gnu.org/viewcvs/gnash/server/character.h?cvsroot=gnash&r1=1.69&r2=1.70 UG> http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.247&r2=1.248 UG> http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.h?cvsroot=gnash&r1=1.99&r2=1.100 comments on this commit: The old sprite_instance-based implementation stored the result of getTarget() and getTargetPath() in a local variable for faster subsequent accesses. However, I removed this cache while moving the functions to character because: - changing character's parent (is that allowed?) would void the cached target and lead to unexpected results - this was a known risk and the old implementation included an assert() that caused re-calculation of the path anyway I think we should not care about caching the value *now* and maybe optimize it later. If one feels analyzing and optimising this anyway: go on! :) Udo
[Prev in Thread] | Current Thread | [Next in Thread] |