Re: Fake mode for testing AT sms-es

[Pawel Kot]

On Wed, 1 May 2002, Pavel Machek wrote:

> Hi!
>
> > > Seems to me AT smses are pretty badly tested because it costs money to
> > > test it. Well, with dry_run = 1 you can test without paying money to
> > > your provider. Okay to commit?
> >
> > Well, I like the idea, but I don't like the implementation. Would you mind
> > to add a new field to statemachine or something? I don't want to use the
> > application config in the phone driver.
>
> Why is it bad to access config from phone driver?

Config is a high level thing. Look what we have in the config:
 - phone model,
 - connection type,
 - serial port,
 - locking thing,
 - initlength,
 - bindir
All these are rather user application things. Some of them are things that
parametrize the driver, but the driver itself does not need to read it
from the config.

> I think we surely will need to access config from phone drivers...

I can't see a reason.

> [Look at model = AT. In future, we'll probably need to know *which* at
> model is it, and I don't think it is good to invent types for each
> phone that is there...]

But do you need the config for this? This is the job for the statemachine
(more specifically for the phone info structure).

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku