Re: next step to multiple phones support

[Ladislav Michl]

On Sun, Dec 15, 2002 at 02:23:24PM +0100, BORBELY Zoltan wrote:
[snip]
> Good move. I can help you in the fbus and m2bus cleanup.

cool, fire cvs update then :)

> > PS gn_statemachine is randomly passed as first or last parameter. this
> > makes some troubles to me, because i can't cache too many things in memory
> > and therefore i have to look at headers very often ;). i'd like to see
> > gn_statemachine as last (first) parameter everywhere. objections?
> 
> When I added the state to the incoming functions I wanted to create as
> small patch as possible. IMHO moving state to a "fix" position (first
> or last I don't care) is a good solution.

ok, now we need someone who will decide which possition...

> > +   if (state->link.link_instance)
> > +           free(state->link.link_instance);
> 
> I prefer the "state->link.link_instance = NULL" statement after the free.

i agree.

        ladis