--writephonebook, --deletephonebook (was: --writephonebook options)

[Reiner Steib]

On Mon, Aug 09 2004, Pawel Kot wrote:

> On Fri, 6 Aug 2004, Reiner Steib wrote:
[...]
> Being more serious: this is known, brown-bag bug. 

I agree. :-)

> It was discussed on gnokii ml already few times. The solution is to
> detect the terminal from which we should read the interactive
> answers. I dunno how to do it in portable way. Someone mentioned
> gnupg as the program with the solution for this.

I read about this in some newsgroup.  You can give a different file
descriptor to gpg:

  echo 'sikrit passfres' | ( cat foo.gpg| gpg --passphrase-fd 3 ) 3<&0

> The workaround would be to avoid reading input from the stdin. But
> that's ugly.

Something like "gnokii --writephonebook FILE"?  Why is this ugly?

> You mean: when the location is busy, do not write it? That's not
> correct behaviour.

IMHO it's better than the current behavior.  Well, I even think
everything is better than the current infloop. ;-)


>> (2) How is "--writephonebook --find-free" supposed to work?
>
> For each entry to be written, the first empty location is found and the
> given entry is being written there.
>
>> echo 'Foo Bar;12345678;SM;;0;'|gnokii --writephonebook --find-free
[...]
> Well, there's a bug few lines earlier:
>                 case 'f':
>                         find_free = 0;
>                         break;
> You should read it: find_free = 1
> Could you please change it and re-verify if it works?

Yes, with this change, it works.  Could you please commit it?

The attached patch adds a description of "--find-free" and
"--deletephonebook" to the man page.

A feature request for "--deletephonebook": "end_number" can be either
a number or a keyword end that denotes 'everything till the end' (see
--deletecalendarnote).

Bye, Reiner.

--- gnokii.1    26 Feb 2004 00:01:18 +0100      1.29
+++ gnokii.1    10 Aug 2004 14:22:54 +0200      
@@ -226,13 +226,21 @@
 You can use also \fI\-r\fR or \fI\-\-raw\fR switch to get the raw output.
 You can use it then with \fI\-\-writephonebook\fR. Normally you got verbose 
output.
 .TP 
-.BR "\-\-writephonebook [\-i]"
-reads data from stdin and writes to phonebook
-When \-i option is used, refuses to overwrite existing entries.
+.BR "\-\-writephonebook [\-o|\-\-overwrite] [\-f|\-\-find\-free]"
+reads data from stdin and writes to phonebook.
 Uses the same format as provided by the output of the getphonebook command.
+See below for details.
 .PP
-The format is very simple.  Each line represents one entry.  Fields are
-separated by semicolons.  Semicolons aren't allowed inside a field.  The
+When the \-o or \-\-overwrite option is used, existing entries at a given
+location are overwritten.
+.PP
+When the \-f or \-\-find\-free option is given, 
+.B gnokii
+tries to find a free location.  In this case, you can omit the location field
+in the input data.
+.PP
+The phonebook format is very simple.  Each line represents one entry.  Fields
+are separated by semicolons.  Semicolons aren't allowed inside a field.  The
 fields have to be in this order (the subentries are optional, ie. you can
 repeat all subetry field multiple times, but they have to be alltogether in
 the given order):
@@ -338,6 +346,14 @@
 For the subentry types that don't care about number type (at text files)
 this should be set to 0. 
 
+
+.BR "\-\-deletephonebook  \fImemory_type\fP \fIstart_number\fP 
[\fIend_number\fP]"
+\" [\fIend_number|end\fP]"
+delete entries with \fIstart_number\fR to \fIend_number\fR from the phone
+book in \fImemory_type\fR .
+\" Not implemented yet:
+\" \fIend_number\fR can be either a number or a keyword end that
+\" denotes 'everything till the end'.
 .SS WAP
 .TP 
 .BR "\-\-getwapbookmark \fInumber\fP"

-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/