Re: xgnokii import from file is broken

[Pawel Kot]

On Tue, 10 Aug 2004, Reiner Steib wrote:

> On Sun, Aug 08 2004, Pawel Kot wrote:
>
> > That's just uninitialized memory. I'll commit the fix in few
> > minutes. Or just memset to 0 entry variable in
> > common/gsm-filetypes.c::gn_file_phonebook_raw_parse() at the
> > beginning.
>
> Thanks.  It seems you didn't commit it yet or the public repository
> hasn't been updated yet.

That is correct. I had temporary problems with access to my laptop where I
have the ssh key matching savannah. I'll do it tomorrow.

> @@ -1467,6 +1467,9 @@
>       entry->empty = true;
>       memory_type_char[2] = 0;
>
> +     memset(entry->name, 0, sizeof(entry->name));

Do it memset(entry, 0, sizeof(...)) and move before entry->empty = true
assignment.

> Could you please add an appropriate comment (e.g. /* Not documented in
> the manual yet */) in the (C-) code in the usage() function?  This
> would make it easier for volunteers.

Sure, if I won't forget ;-)

pkot
-- 
mailto:address@hidden
http://www.gnokii.org/