Re: memleaks on gn_cfg_info within cfgreader.c

[Pawel Kot]

Hi Bastien, hi Sander,

On 5/3/05, Bastien Nocera <address@hidden> wrote:
> Sander Wichers <wichers <at> usa.net> writes:
> > There appears to be memory leaking after calling gn_cfg_file_read, which
> > indirectly fills the gn_cfg_info linked lists. I haven't checked the cvs
> > version but I've grepped for gn_cfg_info in 0.6.4 and I don't see any memory
> > being freed on this variable.
> 
> Has anyone tested this patch? Sander, do you have a small test case, or a
> valgrind log before and after?
> Pawel, I think something like this should be added, as I find very probable 
> that
> there would be some memory leaks related to configuration parsing and reading 
> in
> the current code.

The patch looks fine. But it just adds the possibility to free the
resources. But I'd like to see the real usage of this. I think this
structure needs to live as long as the program is not terminated, so
you would just free the memory on the exit, so i think it doesn;t
matter.

take care,
pkot
-- 
Pawel Kot
http://www.gnokii.org/