Re: Bug in common/phones/atgen.c

[Pawel Kot]

Hi,

On 6/29/05, Pawel Kot <address@hidden> wrote:
> Hi Daniele,
> 
> On 6/29/05, Daniele Forsi <address@hidden> wrote:
> > Alle 21:05, mercoledì 29 giugno 2005, Pawel Kot ha scritto:
> >
> > > Are you sure it was intentional? I haven't look at the code yet, but
> > > it seems to be intentional.
> >
> > uhm, looking again at the source, I think that it was itentional for
> > AT_CHAR_UCS2 but it was NOT for AT_CHAR_HEXGSM or char_hex_encode() was
> > changed later in common/gsm-encoding.c
> 
> Yes, I loooked at the code and think the same. For now I will apply
> the hexgsm part and will do some tests to see if ucs2 should be also
> needed (just to be sure).

After looking closer I applied both parts. They both seem to be valid
(in char_ucs2_encode() there's i_len += length which skips over the
characters in the input). Hope it won't cause any trash on the output.

take care,
pkot
-- 
Pawel Kot
http://www.gnokii.org/