Re: g_malloc / g_strdup in xgnokii_lowlevel.c

[Pawel Kot]

Hi,

On 2/21/06, Daniele Forsi <address@hidden> wrote:
> and so I removed the two and two more, then it seems that the logic
> behind the assignment to phoneMonitor.phone.version is broken since it
> is a duplicate of revision in the first place (see my first post quoted
> above!).

Indeed.

> Below is my proposed change, deleting the g_malloc()'s and adding a
> g_strdup() to copy the string such as "NHM-6" as "version", so the
> options dialog is ok (it has max length 7 for
> configDialogData.phone.version hinting that a short string like that was
> expected) and the debug lines print

Looks fine. Seems that nobody pays much attention to it ;-) Would you commit?

thanks,
pkot
--
Pawel Kot
http://www.gnokii.org/