Re: Nokia 6155 on Gentoo 2006.1 with Gnokii 0.6.14 - some progress

[Mark Kirkwood]

Pawel Kot wrote:
> Thank you. Few notes:
> - always use diff -u format

Sorry (other projects I work with demand -c, diff confusion on my 
part!). I'm happy to redo 'em as -u, but as your next point indicates, 
we need a way to handle support for the various 2.6.x kernels, so for 
now I'll hold off!

> - as we keep the driver outside the mainline we need to support more
> than latest kernel (and with your patch it won't work with 2.6.17)

Right - the 1st patch for 2.6.17 needs just the module_param change, 
whereas the 2.6.18 patch needs module_param *and* the serial.h include 
changes. Obviously older kernels need it the way it is now! So we need 
to add some defines and get configure to probe what version the kernel 
is we are linking against - I don't know how to do this right now, but 
sounds like something configure should be able to do :-).

The simpler (but not so nice) solution is to have more files like 
nokia_dku2.c.2_6_15 etc.

> - what is S_IRUGO?

module_param needs a perm like chmod(2) uses, and  S_IRUGO is defined in 
 include/linux/stat.h to be:

#define S_IRUGO         (S_IRUSR|S_IRGRP|S_IROTH)


> - is module_param lower case right now?

Yes - as of 2.6.17, 2.6.18 and 2.6.19 (wow 3 points releases - must be 
here to stay!)

Cheers

Mark