Re: FBUS speed change to 19200 and 115200

[Pawel Kot]

Hi,

On Nov 21, 2007 10:34 PM, Jari Turkia <address@hidden> wrote:
> Pawel Kot wrote:
>
> > Go ahead. I will try to test it with dlr3p cable and 6210 and 6310 models.
>
> Guess what! I finally cracked it. The patch is included. It has nothing
> to do with baud-rate.
>
> First you need to increase the sleep into 50000 usecs. The command
> simply does not sink in very fast.

That should not matter. You would just loop more times with 50.

> Secondly you cannot free the device instance on FBUS terminate-command.
> On init there will be three attempts. Two of them will fail due to
> already lost device instance. In my case the 3rd one will succeed if
> there still is a device instance to refer.

Sorry, I don't get it.

> Additionally (from fbus.c):
>     res = device_read(buffer + offset, 255, state);
> That has a potential buffer overflow. What happens when command returns
> over 255 characters?

Fixed. Well spotted.

take care,
pkot
-- 
Pawel Kot