Re: [PATCH] Add gn_phonebook2vcardstr()

[Daniele Forsi]

2008/6/13 Bastien Nocera wrote:

> But here's a patch to add a function to transform phonebook entries into
> a string, instead of just pushing it to a file descriptor.

there is similar code in common/gsm-sms.c used only by gn_sms2mbox(),
except the 75 chars limit (it should be 78 for RFC-2822 messages, but
may be up to 998, I don't know about mbox), maybe the same code can be
used in both places

I see that I made a weird thing when adding \r in
http://cvs.savannah.gnu.org/viewvc/gnokii/common/vcard.c?root=gnokii&r1=1.31&r2=1.32
I removed \n from format strings and added \r\n to the replacement of fprintf()

the only excuse is that this way I don't risk splitting \r\n pairs in the middle
I wonder if we should use proper format strings and split only if 76th
char is neither \r nor \n
-- 
Daniele Forsi