Re: [PATCH] Using smsd to send multiline sms

[Pawel Kot]

Hi,

On Fri, Jul 18, 2008 at 19:22, Jan Derfinak <address@hidden> wrote:
> On Fri, 18 Jul 2008, Pawel Kot wrote:
>
>> > It returns NULL, but do not change destination string.
>>
>> And I expect such behaviour in the code above.
>>
>> > The idea of my construction is that memset initialize memory of the string
>> > with 0.
>>
>> My point is that it is too much (especially data.text is quite large).
>
> So that only objection is that it is too expensive?

Don't get me wrong. I don't say your code is wrong or incorrect. You
asked for comments and I'd just written the code the other way. I
think my version explicitely shows that the string is null-terminated,
but I'm perfectly fine with your version as well.

> Text is defined as 10 * GN_SMS_MAX_LENGTH + 1 = 1601b. It is less
> than page size. Do you thing that unconditionaly zeroing 1601b of continuous
> data is much more expensive that branching and assigning?

Yeah. I really thought so. And I am really suprised by the results below.

take care,
pkot
-- 
Pawel Kot