Re: smsd crash report

[Jan Derfinak]

On Fri, 13 May 2011, Pawel Kot wrote:

Hello Pawel.

> While looking at the root cause of the problem described below, I've
> come across that the sending from SMSD is not quite optimal. I may be
> wrong as the smsc is stored somewhere in the data* structure being
> passed to A_SendMessage() but could not trace that. If you ack the
> patch below I'll push it.
> 

You are right, it is not passed in any structure but checked before any
send.

> On the other hand in 99.999% cases SMSC does not change often or does not
> change at all.  It is safe to get the value once and then cache it for the
> subsequent runs.

If we can rely on assumption above your patch seem to be OK, please apply.
I only advise to change local variable name "number" to "smsc_number" and
"type" to "smsc_type" to be more explanatory.
Thanks.

Best regards
Jan


--