RE: Problem with gnokii 0.6.31git, smsd segmentation fault

[João Areias]

Ok, it worked.
It gives an error in logs:
... unsuccessful. Error: Command failed. Event 0 failed with return code 1!

And tries 4 times.

But the daemon doesn't end :)

Thank you all.



João Areias
............................................................................
.........................................................
Interacesso - Nortenet
Avenida Dias da Silva N 230, 1º 
3000 - 135 Coimbra - Portugal
Tel. (+351) 707 220 230 . Fax (+351) 707 220 239
address@hidden
www.interacesso.pt
AVISO
Esta mensagem (incluindo quaisquer anexos) pode conter informação
confidencial para uso exclusivo do destinatário. Se não for o destinatário
pretendido, não deverá usar, distribuir ou copiar este e-mail. Se recebeu
esta mensagem por engano, por favor informe o emissor e elimine-a
imediatamente. Obrigado. 


-----Mensagem original-----
De: address@hidden
[mailto:address@hidden Em nome
de Jan Derfinak
Enviada: segunda-feira, 6 de Junho de 2011 01:38
Para: Discussion forum for gnokii users.
Assunto: Re: Problem with gnokii 0.6.31git, smsd segmentation fault

On Sun, 5 Jun 2011, Daniele Forsi wrote:

> 2011/6/5 Jan Derfinak:
> > On Wed, 1 Jun 2011, Daniele Forsi wrote:
> 
> >> set the reference number on unallocated memory, but maybe instead 
> >> of the fix I pushed we should be clearing the memory somewhere in 
> >> smsd
> >
> > Can you explain what you mean? The code in A_SendSMSMessage clears 
> > data,
> 
> I think that d->sms isn't cleared

Yes, I found the code. It is in mysql.c:DB_Look():
do
{
  error = WriteSMS (&sms);
  sleep (1);
}
while ((error == GN_ERR_TIMEOUT || error == GN_ERR_FAILED) && numError++ <
3);

I think that it is not good that gnokii lib modifies gn_sms structure.
So we need submit a copy of gn_sms structure to gn_sms_send() to be safe.

Please try the attached patch and let me know it helped.

Thank you.

Jan

--