Re: Patch for better Samsung B2100 support

[grunge]

I've enhanced the patch to add support for writephonebook on this phone.
Had to introduce new write_unencoded_number and write_unencoded_name
driver flags for this as the phone retuns encoded number on read but
needs both number and name to be written unencoded.

With this patch, both readphoonebook and writephonebook work with
Samsung B2100, although writephonebook's -o (overwrite) option seems to
have no effect, the phone probably uses some internal find-free function
when storing numbers. I haven't tested it with non-ASCII names, so I
have no idea what character encoding should be used in such a case,
however with ASCII-only names it works fine.
Regards,

grunge

PS: the patch is against gnokii-0.6.30+dsfg-1 (from Debian Wheezy), hope
it's not a problem as it's simple enough to fit other versions too.

On Wed, Jul 13, 2011 at 11:59:42PM +0200, grunge wrote:
> Hello,
> 
> I've tried to backup numbers from my new Samsung B2100 today and had to
> develop attached patch in order to make it work correctly.
> 
> Is this the right place to post this patch to get included in gnokii's
> upstream?
> Regards,
> 
> grunge
> 
> PS: I've also found out that some  commandline parsing fails when
> POSIXLY_CORRECT is set, due to getopt_long's reaction on that
> (try POSIXLY_CORRECT=1 gnokii --getphonebook ME 1 1 -r). Maybe it should get
> documented somewhere.
> 

-- 
NOTE FOR WINDOWS (TM) USERS:  IN NO EVENT UNLESS REQUIRED BY APPLICABLE
LAW WILL I BE LIABLE TO YOU FOR ANY SW OR HW DAMAGE, SYSTEM MALFUNCTION,
DATA LOSS AND/OR DATA BREACH ARISING OUT WHILE YOU ARE READING THIS NOTE.

gnokii-samsung-b2100-readphonebook+writephonebook.patch
Description: Text Data