Re: gnokii-0.6.30 patch

[Pawel Kot]

Hi,

On Thu, Oct 20, 2011 at 10:29, Alexander V. Lukyanov <address@hidden> wrote:
> On Thu, Oct 20, 2011 at 09:29:04AM +0200, Pawel Kot wrote:
>> This is direct caller. The real caller is
>> gn_sm_functions(GN_OP_GetSMSCenter, data, state). The phone will not
>> respond with sms center information when not requested. It should be
>> allocated always before calling this function. And I believe it does.
>
> GN_OP_GetSMSCenter is called from A_SendSMSMessage, but what does happen
> if an SMS is received before sending first SMS?

Nothing. GN_OP_GetSMSCenter is not relevant for reading SMS.

>>     while ((error == GN_ERR_TIMEOUT || error == GN_ERR_FAILED) &&
>> numError++ < 3);
>>
>> in [*] it is cleared. However it might be possible that something is
>> going badly in the retries loop. I'll have a closer look.
>
> When error GN_ERR_TIMEOUT or GN_ERR_FAILED happens, WriteSMS is called again
> with the same sms without any clearing.

Yes, that's what I suspect might happen. However in current git no
need to zero parts field.

take care
-- 
Pawel Kot