[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [3/3]: Patch smsd/sqlite: Several bug fixes / optimizations
From: |
Daniele Forsi |
Subject: |
Re: [3/3]: Patch smsd/sqlite: Several bug fixes / optimizations |
Date: |
Sat, 23 Mar 2013 12:40:23 +0100 |
2013/3/23 Pedro Aguilar:
> This patch fixes a corrupted date/time insert in table outbox.
> Without this patch the inserted date had this format:
> 13-03-23 10:26:09
> instead of
> 2013-03-23 10:26:09
>
> Given that the 'insertdate' column in the same table outbox and the
> date/time columns in the inbox tables use the format YYYY-MM-DD hh:mm:ss, I
> assumed that the format YY-MM-DD hh:mm:ss was not valid.
in the patch you are changing more than that, so better you split the patch
this change needs to be documented both in ChangeLog and in smsd/ChangeLog
this patch uses tabs instead of spaces
--
Daniele Forsi